RFR (S): CR 8004318/JEP 171 Fences intrinsics

Vladimir Kozlov Vladimir.Kozlov at oracle.com
Tue Dec 4 11:47:35 PST 2012


Aleksey,

Add cases into the switch in "if (!InlineNatives)" since this should not 
be controlled by -XX:-InlineNatives flag. There is separate flag for 
unsafe methods: -XX:-InlineUnsafeOps.

You don't need next code since you don't need to check for available 
mach instructions:

  440   case vmIntrinsics::_loadFence:
  441   case vmIntrinsics::_storeFence:
  442   case vmIntrinsics::_fullFence:
  443     break;
  444

Thanks,
Vladimir

On 12/03/12 14:20, Aleksey Shipilev wrote:
> (submitting this on behalf of Doug Lea)
>
> Hi,
>
> Please see the preliminary webrev for changes associated with JEP 171
> aka Fences [1]. The webrev is here:
>    http://shipilev.net/pub/jdk/hotspot/fences/webrev-1/
>
> Testing:
>   - built and tested on Linux x86_64
>   - java-concurrency-torture [2] fences tests [3] passes on Linux x86_64
>   - looking through generated assembly for torture tests
>
> Please review the code changes while this thing flies through JPRT and
> JEP is being "funded".
>
> Thanks,
> Aleksey.
>
> [1] http://openjdk.java.net/jeps/171
> [2] https://github.com/shipilev/java-concurrency-torture
> [3] java -jar concurrency-torture.jar -t ".*fences.*"


More information about the hotspot-compiler-dev mailing list