RFR (XS): CR 8004330: Add missing Unsafe entry points for addAndGet() family
Aleksey Shipilev
aleksey.shipilev at oracle.com
Wed Dec 5 03:34:28 PST 2012
Friendly reminder to check this didn't fall into the trenches.
-Aleksey.
On 12/04/2012 02:42 AM, Aleksey Shipilev wrote:
> (I should have CC'ed Doug on this, doing now).
>
> -Aleksey.
>
> On 12/04/2012 02:36 AM, Aleksey Shipilev wrote:
>> (again, submitting on behalf of Doug Lea)
>>
>> Hi,
>>
>> This simple change is missing from recently committed CR 7023898. While
>> the VM support is there in Hotspot, no methods are exposed in Unsafe to
>> actually make use of those intrinsics. This is the webrev fixing that:
>> http://shipilev.net/pub/jdk/hotspot/unsafe-getandadd/webrev-1/
>>
>> Testing:
>> - Built and tested in Linux x86_64
>> - Doug had provided the AtomicIntegerV8 [1] version making use of this
>> new code, extensively tested on his platforms
>> - java-concurrency-torture [2] atomicity tests [3] are passed for
>> AtomicIntegerV8 on my and Doug's platforms
>> - no other testing is expected for this trivial change.
>>
>> I would need a sponsor to push this change.
>>
>> Thanks,
>> Aleksey.
>>
>> [1]
>> https://github.com/shipilev/java-concurrency-torture/blob/master/src/main/java/java/util/concurrent/atomic/AtomicIntegerV8.java
>> [2] https://github.com/shipilev/java-concurrency-torture/
>> [3]
>> https://github.com/shipilev/java-concurrency-torture/blob/master/src/main/java/org/openjdk/concurrent/torture/tests/atomics/integer/AtomicIntegerV8PairwiseTests.java
>>
>
More information about the hotspot-compiler-dev
mailing list