Build error after CR#7172640 with GCC4.7.2

[Christian Thalinger]

On Dec 9, 2012, at 8:10 PM, Yasumasa Suenaga <suenaga.yasumasa at lab.ntt.co.jp> wrote:

> Hi,
> 
> When I build hsx/hotspot-comp with GCC 4.7.2 on Fedora17, it fails with message as following:
> 
> ----------
> /usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp: In member function 'CallGenerator* Compile::make_vm_intrinsic(ciMethod*, bool)':
> /usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:415:67: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
> /usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:418:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
> /usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:421:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
> /usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:424:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
> cc1plus: all warnings being treated as errors
> make[6]: *** [library_call.o] Error 1
> ----------
> 
> Cause of this problem is that Compile::make_vm_intrinsic() should return pointer type
> (CallGenerator*), however patch of CR#7172640 returns boolean value.

Good catch.  I messed that up.

> 
> 
> I posted this problem on BugDatabase as a new bug (Internal review ID is 2396515).
> However, it does not seem to public yet.
> 
> I've made a patch which attached in this email, and it works fine in my environment.
> I would like to contribute this patch, and I hope to merge this patch into mainline.

Did you or your company sign the OCA?  If yes, I'd happily add you as a contributor to this changeset.  If not, I will just fix it myself and push it (since it's a trivial change).

I filed:

8004898: library_call.cpp build error after 7172640 with GCC 4.7.2

-- Chris

> 
> Please cooperate.
> 
> 
> Best regards,
> Yasumasa
> 
> <builderr-gcc47.patch>