RFR(M): pass outputStream to more opto debug routines

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Dec 13 18:03:59 PST 2012


Thank you, Goetz, for doing this.

Changes are good. One thing I want to ask you is a small codding style 
cleanup. We are converting all cases of "if( a )" to "if (a)" in a 
methods we touch. And I see you have cases like that.

Thanks,
Vladimir

On 12/13/12 2:49 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> We pass the outputStream to much more debug routines than openJDK does,
>
> as we write a lot more information to files e.g., in case of a crash.
>
> I would like to contribute the changes that allow to pass the output
> stream to
>
> node->dump() and everything reachable from there.
>
> This also fixes the usage of output stream in print_register_type() in
> oopMap.cpp and
>
> in MachNullCheckNode::format(), where a single print command still used tty.
>
> Further we initialize _node_regs_max_index so that
> node_regs_max_index()  == 0
>
> indicates that registers of a node can be accessed.  This is also useful in
>
> debug output.
>
> http://cr.openjdk.java.net/~goetz/webrevs/webrev-os_in_nodeDump/
>
> Best regards,
>
>    Goetz.
>


More information about the hotspot-compiler-dev mailing list