RFR (M): 8004835: Improve AES intrinsics on x86

[Vladimir Kozlov]

http://cr.openjdk.java.net/~kvn/8004835/webrev/

Enable AES intrinsics on non-AVX cpus (Westmere), pshufb instruction in 
load_key() method could be used without AVX because it references only 
aligned memory "key_shuffle_mask".

Group together aes instructions in encryptBlock/decryptBlock stubs as 
recommended by Intel Optimization Guide.

Modified test/compiler/7184394 to test "ECB" mode.

Ran compiler regression tests and jdk crypto and security tests with 
SunJCE default provider.

Thanks,
Vladimir


On 11/6/12 9:46 AM, Deneau, Tom wrote:
> Thanks for the update...
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Tuesday, November 06, 2012 11:42 AM
> To: Mikael Vidstedt
> Cc: Deneau, Tom; Harle, Christophe; Venkatachalam, Vasanth
> Subject: Re: review request: 7184394: add intrinsics to use AES instructions
>
> The changes were promoted to jdk8b63 last week. We have to wait about 2 weeks of
> JDK testing to make sure it does not brake anything. After that I will backport
> it into 7u12.
>
> Regards,
> Vladimir
>
> Mikael Vidstedt wrote:
>>
>>
>> Vladimir - can you please give Tom a status update?
>>
>> Cheers,
>> Mikael
>>
>> On 2012-11-06 08:31, Deneau, Tom wrote:
>>> Mikael --
>>>
>>> Any update on this as far as getting it into 7u12?
>>> I see that the webrev was checked into the hotspot trunk on Oct 24.
>>>
>>> -- Tom
>>>
>>> -----Original Message-----
>>> From: Mikael Vidstedt [mailto:mikael.vidstedt at oracle.com]
>>> Sent: Thursday, October 11, 2012 1:12 PM
>>> To: Deneau, Tom
>>> Cc: Vladimir Kozlov; Caspole, Eric; Harle, Christophe; Joshi, Shrinivas
>>> Subject: Re: review request: 7184394: add intrinsics to use AES
>>> instructions
>>>
>>>
>>> It does, and very specifically it enables us to check it into the
>>> development branch through one of the group repositories. When it's been
>>> integrated and has gone through the necessary testing we will be able to
>>> backport it to jdk7.
>>>
>>> Cheers,
>>> Mikael
>>>
>>> On 2012-10-11 11:07, Deneau, Tom wrote:
>>>> Mikael --
>>>>
>>>> OK, there was a question on our Oracle-AMD call as to whether JEP
>>>> publication would enable something to get checked into *some* hotspot
>>>> repository, even if it was not the repository to be used for the next
>>>> update.
>>>>
>>>> -- Tom
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Mikael Vidstedt [mailto:mikael.vidstedt at oracle.com]
>>>> Sent: Thursday, October 11, 2012 12:54 PM
>>>> To: Deneau, Tom
>>>> Cc: Vladimir Kozlov; Caspole, Eric; Harle, Christophe; Joshi, Shrinivas
>>>> Subject: Re: review request: 7184394: add intrinsics to use AES
>>>> instructions
>>>>
>>>>
>>>> The JEPs do not mention releases, it describes the enhancement ("why?"
>>>> and "what?").
>>>>
>>>> Now that we have the JEP we can proceed with the rest of the work - I'm
>>>> working to make sure we get this picked up and integrated asap!
>>>>
>>>> Cheers,
>>>> Mikael
>>>>
>>>> On 10/11/2012 10:46 AM, Deneau, Tom wrote:
>>>>> Vladimir --
>>>>>
>>>>> I see that the JEP for this has been published
>>>>> http://openjdk.java.net/jeps/164 but not yet approved for a
>>>>> particular JDK7 update.  Does the JEP publication make any
>>>>> difference as far as checking this in?
>>>>>
>>>>> -- Tom
>>>>>
>>>>> -----Original Message-----
>>>>> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
>>>>> Sent: Wednesday, August 22, 2012 12:07 PM
>>>>> To: Deneau, Tom
>>>>> Cc: Caspole, Eric; Harle, Christophe; Joshi, Shrinivas; Mikael Vidstedt
>>>>> Subject: Re: review request: 7184394: add intrinsics to use AES
>>>>> instructions
>>>>>
>>>>> Code seems good. As I understand only formalities left, Oracle wants
>>>>> AMD to file
>>>>> formal JEP openjdk project and follow corresponding procedures (I
>>>>> can't help
>>>>> with that).
>>>>>
>>>>> We are skipping 7u8 (it will be derived from 7u6 sources). Current
>>>>> HS24 sources
>>>>> will go into 7u10 which will be "last" update for jdk7. We will do
>>>>> fork of HS24
>>>>> into 7u10 next week (may be). But I will be able to put these
>>>>> changes there if
>>>>> it will be approved for 7 update. We will have several months to put
>>>>> things into
>>>>> 7u10.
>>>>>
>>>>> Vladimir
>>>>>
>>>>> Deneau, Tom wrote:
>>>>>> Hi Vladimir --
>>>>>>
>>>>>>
>>>>>> I am back from vacation.   Can I get an update on 7184394: add
>>>>>> intrinsics to use AES instructions?
>>>>>>
>>>>>> I know Eric took care of some reviewer comments a few weeks ago but we
>>>>>> have not heard anything since then.
>>>>>>
>>>>>>
>>>>>> I realize there are other hurdles for getting this into 7U8 but I was
>>>>>> just curious about the status of getting it into the trunk.
>>>>>>
>>>>>>
>>>>>> -- Tom
>>>>>>
>>>>>>
>>>>
>>>
>>>
>>
>
>