RFS(M): 8005031: Some cleanup in c2 to prepare for incremental inlining support

Christian Thalinger christian.thalinger at oracle.com
Mon Dec 17 11:01:23 PST 2012


On Dec 17, 2012, at 10:41 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On Dec 17, 2012, at 8:49 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
> 
>>>>> PrintInliningChunk --> PrintInliningEvent
>>>>> _print_inlining_chunks --> _print_inlining_list
>>> 
>>> While I'm in favor of using something else than Chunk it seems that Event is not a good name choice given all the JFR events coming soon.  Maybe Message?
>> 
>> What about PrintInliningBuffer (often, there will be more than one inlining message per buffer) and _print_inlining_list?
> 
> Sounds good.  -- Chris

I have one more question:

src/share/vm/opto/library_call.cpp:

-    args[which_arg] = _gvn.transform(arg);
+    args[which_arg] = arg;

Why is the transform not necessary?  I guess it's because the incoming arguments are already transformed.

-- Chris


More information about the hotspot-compiler-dev mailing list