Request for reviews (S): 8004250: replace AbstractAssembler a_byte/a_long with emit_int8/emit_int32

[Christian Thalinger]

Looks good.  It's in the JPRT queue.

-- Chris

On Dec 20, 2012, at 5:45 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Thanks for picking this up Christian.
> 
> Here is the updated webrev that just passed its JPRT job.
> 
> Thanks much,
> 
>        --morris
> 
> WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/02/JDK-8004250
> 
> On 12/17/12 8:39 PM, Christian Thalinger wrote:
>> On Dec 13, 2012, at 4:02 PM, Christian Thalinger<christian.thalinger at oracle.com>  wrote:
>> 
>>> Looks good.  -- Chris
>> Actually not:
>> 
>> $ ack -a emit_byte src/
>> src/cpu/x86/vm/macroAssembler_x86.cpp
>> 1026:  emit_byte(0xC9); // LEAVE
>> 2115:    emit_byte(0x26); // es:
>> 2116:    emit_byte(0x2e); // cs:
>> 2117:    emit_byte(0x64); // fs:
>> 2118:    emit_byte(0x65); // gs:
>> 2119:    emit_byte(0x90);
>> 2537:      emit_byte(0x70 | cc);
>> 2538:      emit_byte((offs - short_size) & 0xFF);
>> 2541:      emit_byte(0x0F);
>> 2542:      emit_byte(0x80 | cc);
>> 
>> src/cpu/zero/vm/assembler_zero.cpp
>> 61:    emit_byte(AbstractAssembler::code_fill_byte());
>> 
>> src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp
>> 119:     emit_byte (segment);
>> 128:     emit_byte (segment);
>> 
>> src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp
>> 33:  emit_byte(0xCC);
>> 
>> -- Chris
>> 
>>> On Dec 13, 2012, at 12:15 PM, Morris Meyer<morris.meyer at oracle.com>  wrote:
>>> 
>>>> Folks,
>>>> 
>>>> Could I get a review of this cleanup requested by Christian Thalinger?  This has been tested on JPRT.
>>>> 
>>>> Thanks in advance,
>>>> 
>>>>       --morris meyer
>>>> 
>>>> WEBREV -http://cr.openjdk.java.net/~twisti/8004250/
> 
>