review(XS): 7131288: COMPILE SKIPPED: deopt handler overflow (retry at different tier)
Igor Veresov
igor.veresov at oracle.com
Wed Jan 18 19:31:38 PST 2012
On Wednesday, January 18, 2012 at 7:18 PM, Vladimir Kozlov wrote:
> Why not use should_not_reach_here() in deopt stub?
No problem. I just didn't want to change the original message. Fixed.
> Also x86 deopt stub does not
> have stop() or should_not_reach_here().
Fixed.
I've updated the webrev: http://cr.openjdk.java.net/~iveresov/7131288/webrev.01/
igor
>
> Vladimir
>
> Igor Veresov wrote:
> > After 701291 we started generating should_not_reach() code in product VM in LIR_Assembler::emit_exception_handle()
> > which is significantly bigger than exception_handler_size for product VM. It seems that we generate should_not_reach for all other platforms, so I decided to leave it for sparc too. I adjusted the sizes for stubs so that they are the same in product and debug, which should enable the assert that checks for the overflow to make sense. Did the same for deopt stub too.
> >
> > Webrev: http://cr.openjdk.java.net/~iveresov/7131288/webrev.00/
> >
> >
> > igor
More information about the hotspot-compiler-dev
mailing list