review(S): 7131259: compile_method and CompilationPolicy::event shouldn't be declared TRAPS

Tom Rodriguez tom.rodriguez at oracle.com
Thu Jan 26 10:07:17 PST 2012


Looks good.

tom

On Jan 25, 2012, at 11:34 PM, Igor Veresov wrote:

> On Wednesday, January 25, 2012 at 7:56 PM, Tom Rodriguez wrote:
>> 
>> On Jan 25, 2012, at 7:03 PM, Igor Veresov wrote:
>> 
>>> Make sure that CompilationPolicy::event() doesn't throw exceptions. 
>>> 
>>> Webrev: http://cr.openjdk.java.net/~iveresov/7131259/webrev.01/
>> 
>> In several places the code assumes and checks that the Thread is actually a JavaThread. Could it be changed to be JavaThread all the way through so the checks and casts can be removed? Otherwise it looks good.
>> 
> Good point. Done: http://cr.openjdk.java.net/~iveresov/7131259/webrev.02/
> 
> igor
> 
> 



More information about the hotspot-compiler-dev mailing list