Request for review (XS): 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle

[Christian Thalinger]

Thank you, Tom.  -- Chris

On Jan 30, 2012, at 5:14 PM, Tom Rodriguez wrote:

> Looks good.
> 
> tom
> 
> On Jan 30, 2012, at 2:29 AM, Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/7132180/
>> 
>> 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle
>> Reviewed-by:
>> 
>> The logic for detecting the selectAlternative idiom in
>> GraphBuilder::for_method_handle_inline assumes that both inputs of the
>> phi node are constant.  This might now be the case.
>> 
>> The fix is to check for is_constant on the ObjectType of both inputs.
>> 
>> Tested with failing test.
>> 
>> src/share/vm/c1/c1_GraphBuilder.cpp
>> 
>