Request for reviews (XS): 7123926: Some CTW test crash: !_control.contains(ctrl)

[Krystal Mok]

Hi Vladimir,

foo(Integer intobj) {
  String intstr = intobj.toString();
  String str = intstr + ", " + intstr;

What should be the desired behavior for the case above?
Is it all right to skip all Integer.toString() calls, and let later
optimizations handle it?

And, two typos:

541               // chain. It's node could be eliminated only if it's
result

It's -> Its. Other occurrences of "it's" should also be replaced with "its".

543               // An other limitation: it should be used only once
because

An other -> Another.

- Kris

On Fri, Jul 6, 2012 at 4:37 AM, Vladimir Kozlov
<vladimir.kozlov at oracle.com>wrote:

> Vladimir Kozlov wrote:
>
>> http://cr.openjdk.java.net/~**kvn/7123926/webrev<http://cr.openjdk.java.net/~kvn/7123926/webrev>
>>
>> 7123926: Some CTW test crash: !_control.contains(ctrl)
>>
>> Don't try to eliminate Integer::toString() call node during String
>> concatenation optimization if it's result has several uses.
>>
>> Eliminate case:
>>   foo (Integer intob) {
>>     String str = "int: " + intobj;
>>
>> Keep case:
>>   foo (Integer intob) {
>>     String intstr = intobj.toString();
>>     String str = "int: " + intobj; // second use is in SB allocation
>>
>
> Sorry, it should be: "int: " + intstr;
>
> Vladimir
>
>
>  debug info
>>
>> Tested with failed test.
>>
>> Thanks,
>> Vladimir
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120706/a50af946/attachment.html