Request for reviews (XS): 7123926: Some CTW test crash: !_control.contains(ctrl)

[Krystal Mok]

On Fri, Jul 6, 2012 at 11:34 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com
> wrote:

> > I'm a little bit worried about this part after seeing your fix for
> 7181658. Do you think it's safe to use uncast()
>
> It was another Vladimir (Ivanov) who fixed 7181658 :-)
>
> Oops, I'm sorry guys!


>
> > this way, or should we use eqv_uncast() for comparison at the use sites
> of StringConcat::argument_uncast(**)?
>
> I think using uncast() in argument_uncast() is safe, it is used only in
> related code. The first time argument_uncast() is called to find a Proj
> node from SB.toString() call. Then that Proj node passed to merge() method
> as 'arg'. And in the merge() method argument_uncast() is called second time
> to compare with that passed 'arg'.
>
> Alright. I just needed someone else to confirm it.

Thanks,
Kris


> Thanks,
> Vladimir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120709/e17d870f/attachment.html