Request for reviews (S): 7087357: JSR 292: remove obsolete code after 7085860
Christian Thalinger
christian.thalinger at oracle.com
Fri Jul 13 15:37:17 PDT 2012
On Oct 27, 2011, at 4:29 AM, Christian Thalinger wrote:
> I forgot that we ignore exceptions when registering CallSite methods in JVM_RegisterMethodHandleMethods. This was required during the transition period. But after this change we have to fail on exceptions:
>
> http://cr.openjdk.java.net/~twisti/7087357/src/share/vm/prims/methodHandles.cpp.udiff.html
I would like to push this patch before we integrate our new JSR 292 work. The patch does not change when applied to a current HotSpot version but I updated the webrev anyway. Any objections?
-- Chris
>
> -- Chris
>
> On Sep 15, 2011, at 10:12 AM, Christian Thalinger wrote:
>
>> Thank you, Tom. -- Christian
>>
>> On Sep 14, 2011, at 7:17 PM, Tom Rodriguez wrote:
>>
>>> Looks good.
>>>
>>> tom
>>>
>>> On Sep 14, 2011, at 7:00 AM, Christian Thalinger wrote:
>>>
>>>> This fix will NOT be pushed before the changes of 7085860 have been propagated to all repositories! But I want to do the review now so I can push as soon as the propagation is finished.
>>>>
>>>> http://cr.openjdk.java.net/~twisti/7087357/
>>>>
>>>> 7087357: JSR 292: remove obsolete code after 7085860
>>>> Reviewed-by:
>>>>
>>>> These changes:
>>>>
>>>> 7071653: JSR 292: call site change notification should be pushed not pulled
>>>> 7079673: JSR 292: C1 should inline bytecoded method handle adapters
>>>> 7085404: JSR 292: VolatileCallSites should have push notification too
>>>>
>>>> added code which can be removed if the JDK changes of 7085860 have
>>>> landed.
>>>>
>>>> src/share/vm/classfile/javaClasses.cpp
>>>> src/share/vm/interpreter/interpreterRuntime.cpp
>>>> src/share/vm/prims/unsafe.cpp
>>>>
>>>
>>
>
More information about the hotspot-compiler-dev
mailing list