Request for reviews (S): 7187454: stack overflow in C2 compiler thread on Solaris x86

[Christian Thalinger]

Looks good.  -- Chris

On Jul 27, 2012, at 5:06 PM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/7187454/webrev
> 
> 7187454: stack overflow in C2 compiler thread on Solaris x86
> 
> Solaris C++ compiler use a lot of space on stack in fastdebug build to allocate on stack char[256] (from FormatBuffer used by err_msg()) for each assert. As result VM crashs with stack overflow in C2 compiler threads in recursive methods. It is triggered by changes in the recent 292 push which added err_msg() call in asserts in node.hpp file.
> 
> Added new FormatBufferResource class to use thread's resource area for error message buffer. Added new err_msg_res() to use new class and use it in C2 instead of err_msg(). Removed workaround from makefile for C2 files.
> 
> Thanks,
> Vladimir