Request for reviews (XS): Fix of 6658428, emitting popcount on platforms without support
Vladimir Kozlov
vladimir.kozlov at oracle.com
Mon Mar 12 08:28:04 PDT 2012
The bug id 7152957.
On X86 Count*Zeros instructions are predicated by flag UseCountLeadingZerosInstruction so you need to add check for them
also into match_rule_supported().
Vladimir
On 3/12/12 8:12 AM, Nils Eliasson wrote:
> http://cr.openjdk.java.net/~neliasso/0000000/webrev.01/ <http://cr.openjdk.java.net/%7Eneliasso/0000000/webrev.01/>
>
> Fix of 6658428, emitting popcount on platforms without support
>
> I introduced a bug in the intrinsic fix 6658428. The platform depedent code in Matcher::match_rule_supported didn't take
> actual hardware support into account, only if the matcher on this platforms support it.
>
> Have added checks in match_rule_supported on all platforms inline with what was available on sparc and arm.
>
> I haven't opened a new bug for this, should I do that, or reuse the one that broke things? Here is the fix anyway.
>
> Thanks,
> Nils
More information about the hotspot-compiler-dev
mailing list