7127687: MethodType leaks memory due to interning

[Vitaly Davidovich]

We only care about keys here anyway, right? WeakHashMap with a dummy value
object (some static reference) should achieve the same thing since its
Entry will have the key referenced weakly and the value strongly (but we
don't care since the value is a dummy static ref).  Maybe I misunderstood
the intent though ...

Sent from my phone
On Mar 28, 2012 9:02 PM, "Jim Laskey" <jlaskey at me.com> wrote:

> The WeakHashMap leads to a non-weak reference to the class, since only the
> key is weak. Same is true for public versions of WeakHashSet. The
> collection used here is truly weak.
>
> Sent from my iPhone 4
>
> On 2012-03-28, at 9:42 PM, Vitaly Davidovich <vitalyd at gmail.com> wrote:
>
> Hi John,
>
> I think you can use diamond generic inference when declaring the weak
> intern set.
>
> Also any reason you didn't use WeakHashMap directly with dummy value to
> simulate the set? Or wrap the WeakHashMap and synchronize the accessors to
> it?
>
> Sent from my phone
> On Mar 28, 2012 7:52 PM, "John Rose" <john.r.rose at oracle.com> wrote:
>
>> http://cr.openjdk.java.net/~jrose/7127687/webrev.00/
>>
>> 7127687: MethodType leaks memory due to interning
>> Summary: Replace internTable with a weak-reference version.
>>
>> This is a point fix for JDK 8, and will (pending approval) also be
>> back-ported to JDK 7u.
>>
>> — John
>>
>> Notes on process:  This code is part of JSR 292.  Therefore the review
>> comments will be collected in mlvm-dev, and changes will be integrated via
>> hsx/hotspot-comp.
>>
>> At least one reviewer must be an official Reviewer the JDK 8 Project [1],
>> but other reviewers are most welcome.
>>
>> [1] http://openjdk.java.net/census#jdk8
>>
>> _______________________________________________
>> mlvm-dev mailing list
>> mlvm-dev at openjdk.java.net
>> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>>
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>
>
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120328/fe7b1107/attachment.html