Review Request (S): 8002364 - compile_id is not unique when CICountOSR is set

Nils Eliasson nils.eliasson at oracle.com
Fri Nov 9 05:00:49 PST 2012


Vladimir Kozlov skrev 2012-11-08 19:02:
> It is not true. Vladimir I. changed the flag default value to false in recent changes for 7177003.
> Also in our developing environment we will not use JFR but we want a functionality which help us debug problems. So I would like to keep the flag and have a separate number in output (tty and LogCompilation log) for osr_id if the flag is on. So I agree with your general changes but you need to add more code.

True, that change hadn't propagated to the branch where I originally did 
the work.

Yes, and thats exactly why I kept the functionality by extracting it to 
a separate id and took great care to keep its behavior.

> After thinking about this more, maybe we should always print osr_id as an additional number then we don't need CICountOSR flag. In this case you only need to add code to print this number in PrintCompilation and LogCompilation.
>
> Vladimir
>
Is there any parser or tool that will break if I add the osr_id as an 
additional number?

//N



More information about the hotspot-compiler-dev mailing list