Request for Reviews(M): 7092905: C2: Keep track of the number of dead nodes

[Vladimir Kozlov]

Usually the beginning of next phase comes after the end of previous 
phase so you will have almost duplicated verification and expensive. I 
would prefer to have both PrintIdealNodeCount and VerifyIdealNodeCount 
at the end to show how the phase affected nodes count. The only reason I 
suggested to move only VerifyIdealNodeCount is that TracePhase does not 
have phase's name which I think is easy to fix and it will be nice to 
print also.

Thanks,
Vladimir


On 11/12/12 08:59, Bharadwaj Yadavalli wrote:
> Thanks for the review, Vladimir.
>
> On 11/8/2012 7:54 PM, Vladimir Kozlov wrote:
>> I think VerifyIdealNodeCount code should be in ~TracePhase() (end of
>> phase).
>>
>
> I am wondering if PrintIdealNodeCount and VerifyIdealNodeCount should be
> both in the constructor and destructor of TracePhase.
>
> This will allow us to track the node counts both at the entry of the
> phase (when the constructor is executed) and at the exit of the phase
> (when the destructor is executed).
>
> What do you think?
>
> Bharadwaj
>