Request for reviews (XS): 7146636: compiler/6865265/StackOverflowBug.java fails due to changed stack minimum

[Vladimir Kozlov]

Looks good.

I will push it for you on Monday.

Thanks,
Vladimir

On 11/16/12 13:24, David Chase wrote:
> Please review changes at http://cr.openjdk.java.net/~drchase/JDK-7146636/webrev.00/
>
> Bug: A change in the minimum stack size on Solaris-sparc caused compiler/6865265/StackOverflowBug.java to fail to run; the run parameters specified a stack size too small for the VM to properly start.
>
> Fix: Increase the stack size in the run parameters.
>
> Testing: verified the failure first (specific to sparc+solaris).  Applied fixes, the test now runs and passes.
>
>
> I went looking to see if there was a hardwired constant that should be tagged with a watch-out-if-you-change-it, but instead found
>
>    Solaris::min_stack_allowed = MAX2(thr_min_stack(), Solaris::min_stack_allowed);
>    ...
>    os::Solaris::min_stack_allowed = MAX2(os::Solaris::min_stack_allowed,
>              (size_t)(StackYellowPages+StackRedPages+StackShadowPages+
>                      2*BytesPerWord COMPILER2_PRESENT(+1)) * page_size);
>
> in hotspot/src/os/solaris/vm/os_solaris.cpp
>
> Thanks much,
>
> David
>