RFR (S): Issue constants to constant pool in stub code

[Vitaly Davidovich]

Hi Goetz,

I think the assert message in assembler.cpp (line 107) needs adjustment
since cs can also be stubs now.

Thanks

Sent from my phone
On Nov 20, 2012 5:07 AM, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
wrote:

> Hi,****
>
> ** **
>
> When adding constants to the constant pool, the code_section is switched**
> **
>
> to the constant pool code_section, and then back again.  It was hard coded
> ****
>
> to switch back to the code_section for code.****
>
> If constants are issued in stubs, it is switched back to the wrong code
> section.****
>
> I changed the code to remember the code section and switch back to the
> proper****
>
> one.  ****
>
> Further it’s necessary to relocate only after copying code and stub
> section to ****
>
> a new location, as the relocation might affect an address in the stub
> section.****
>
> ** **
>
> You can find these changes here:****
>
> http://cr.openjdk.java.net/~goetz/webrevs/webrev-const_in_stub/****
>
> ** **
>
> or in our ppc port:****
>
> http://hg.openjdk.java.net/ppc-aix-port/jdk7u/hotspot/rev/b288e82d9062****
>
> ** **
>
> Thank you and best regards, ****
>
>   Goetz****
>
> ** **
>
> ** **
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20121120/45b732c1/attachment.html