RFR (S): Issue constants to constant pool in stub code

[Christian Thalinger]

On Nov 20, 2012, at 2:05 AM, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

> Hi,
>  
> When adding constants to the constant pool, the code_section is switched
> to the constant pool code_section, and then back again.  It was hard coded
> to switch back to the code_section for code.
> If constants are issued in stubs, it is switched back to the wrong code section.
> I changed the code to remember the code section and switch back to the proper
> one. 
> Further it’s necessary to relocate only after copying code and stub section to
> a new location, as the relocation might affect an address in the stub section.
>  
> You can find these changes here:
> http://cr.openjdk.java.net/~goetz/webrevs/webrev-const_in_stub/

That's a nice fix.  Recently I touched this code and I was worried about that also.  I suppose on PPC you only use address_constant in stubs.  What about the other constant emitting methods?

-- Chris

>  
> or in our ppc port:
> http://hg.openjdk.java.net/ppc-aix-port/jdk7u/hotspot/rev/b288e82d9062
>  
> Thank you and best regards,
>   Goetz
>