RFR (S) 8001538: hs_err file does not list anymore compiled methods in compilation events

[Vladimir Ivanov]

Yes, I plan to push it today.

Best regards,
Vladimir Ivanov

On 11/21/12 6:57 AM, Vladimir Kozlov wrote:
> Vladimir I. can do it himself since he is Committer now.
>
> Vladimir K.
>
> On Nov 20, 2012, at 6:40 PM, Christian Thalinger wrote:
>
>>
>> On Nov 19, 2012, at 11:14 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>>
>>> Vladimir K., Chis, thanks.
>>
>> Is someone going to push this change?
>>
>> -- Chris
>>
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>>
>>> On 11/19/12 9:09 PM, Christian Thalinger wrote:
>>>> Looks good.  -- Chris
>>>>
>>>> On Nov 15, 2012, at 9:33 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>>>>
>>>>> Vladimir K., Chris, thank you for the review.
>>>>>
>>>>> Yes, it restores original compilation events format [1]
>>>>>
>>>>> I verified that it's safe to use objects from resource area for logging: event logger copies message content into internal buffer.
>>>>>
>>>>> Updated webrev:
>>>>> http://cr.openjdk.java.net/~vlivanov/8001538/webrev.01/
>>>>>
>>>>> Best regards,
>>>>> Vladimir Ivanov
>>>>>
>>>>> [1] http://cr.openjdk.java.net/~vlivanov/8001538/webrev.01/hs_err_pid87677.log
>>>>>
>>>>> On 11/13/12 7:41 PM, Vladimir Kozlov wrote:
>>>>>> Very nice fix, Vladimir I., thank you
>>>>>>
>>>>>> To confirm, the size fix restored methods names in compilation events. Right?
>>>>>>
>>>>>> You moved deoptimization event logging under resourceMark, make sure the logging code does not use resource area or copied from it to safe place.
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir
>>>>>>
>>>>>> On Nov 13, 2012, at 7:53 AM, Vladimir Ivanov wrote:
>>>>>>
>>>>>>> http://cr.openjdk.java.net/~vlivanov/8001538/webrev.00/
>>>>>>>
>>>>>>> Due to incorrect message buffer size calculation, a message may be truncated to 4/8 characters.
>>>>>>>
>>>>>>> Also, changed how deoptimization events are logged:
>>>>>>> - moved [1] from "Deoptimization events" to "Events" section.
>>>>>>> - added [2] to "Deoptimization events" section
>>>>>>>
>>>>>>> Sample output from a hs_err file:
>>>>>>> Deoptimization events (2 events):
>>>>>>> Event: 3.438 Thread 0x0000000103804800 Uncommon trap: Test::f @ 23, reason: unloaded, action: reinterpret
>>>>>>> Event: 3.482 Thread 0x0000000103804800 Uncommon trap: Test::main @ 38, reason: unloaded, action: reinterpret
>>>>>>>
>>>>>>> Internal exceptions (10 events):
>>>>>>> ...
>>>>>>>
>>>>>>> Events (10 events):
>>>>>>> Event: 3.441 Thread 0x0000000103804800 DEOPT UNPACKING pc=0x00000001046cf214 sp=0x0000000100700548 mode 2
>>>>>>> Event: 3.482 Thread 0x0000000103804800 Uncommon trap 3 fr.pc 0x00000001046ffe1c
>>>>>>> ...
>>>>>>>
>>>>>>> Testing: JPRT, simple test w/ deopt events in the log.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Vladimir Ivanov
>>>>>>>
>>>>>>> [1] Uncommon trap 3 fr.pc 0x00000001046ffe1c
>>>>>>> [2] Uncommon trap: Test::f @ 23, reason=unloaded action=reinterpret
>>>>>>
>>>>
>>
>