Removing LogCleanUpReader
Mikael Vidstedt
mikael.vidstedt at oracle.com
Mon Nov 26 08:45:33 PST 2012
I don't know how this exact tool is being used, but we can continue
improving it in the older branches if needed. If it doesn't work with
the current version it should be deprecated and removed, otherwise we'll
just end up with lots of effectively dead code over time, right?
Cheers,
Mikael
On 11/22/2012 11:12 PM, Vladimir Kozlov wrote:
> Current version has more fixes in it and we can extract more information from logs from previous VM versions. Why kill compatibility if we can keep it without any cost to us?
>
> Regards,
> Vladimir
>
> On Nov 22, 2012, at 5:54 PM, Mikael Vidstedt wrote:
>
>> That in itself isn't a reason to keep it, you can always get the code from the version control system. More important is whether it's helpful for the current sources and if anybody is actually using it?
>>
>> Cheers,
>> Mikael
>>
>> On 2012-11-15 09:00, Vladimir Kozlov wrote:
>>> No, keep it. LogCompilation tool is not release dependent so we can build it from current sources and use it to parse logs from previous jdk releases.
>>>
>>> Vladimir
>>>
>>> On 11/15/12 01:12, Nils Eliasson wrote:
>>>> Anyone against removing the LogCleanUpReader from share/tools?
>>>>
>>>> According to the comments it was used for 1.5/1.6 to handle malformed
>>>> xml from LogCompilation.
>>>>
>>>> //Nils
More information about the hotspot-compiler-dev
mailing list