RFR (XXL): 8003240: x86: move MacroAssembler into a separate file

Vladimir Kozlov Vladimir.Kozlov at oracle.com
Wed Nov 28 21:01:06 PST 2012


Looks good to me.

Thanks,
Vladimir

On 11/28/12 17:02, Christian Thalinger wrote:
> [Prologue:  The patch is classified as XXL but in fact it's not so bad.  The biggest changes are a verbatim move from assembler_x86.{cpp,hpp} into macroAssembler_x86.{cpp,hpp}.  The rest is adjustments of includes to make everything work.  I also took the liberty to clean up some stuff.]
>
> http://cr.openjdk.java.net/~twisti/8003240/
>
> 8003240: x86: move MacroAssembler into a separate file
> Reviewed-by:
>
> The assembler_<arch>.{cpp,hpp} files are already very big and we should split them into two files:
>
> assembler_<arch>.{cpp,hpp}
> macroAssembler_<arch>.{cpp,hpp}
>
> This is for x86.
>
> src/share/vm/asm/macroAssembler.hpp
> src/share/vm/asm/macroAssembler.inline.hpp
> src/cpu/x86/vm/assembler_x86.cpp
> src/cpu/x86/vm/macroAssembler_x86.cpp
> src/cpu/x86/vm/assembler_x86.hpp
> src/cpu/x86/vm/macroAssembler_x86.hpp
> src/cpu/x86/vm/assembler_x86.inline.hpp
> src/cpu/sparc/vm/assembler_sparc.cpp
> src/cpu/sparc/vm/codeBuffer_sparc.hpp
> src/cpu/sparc/vm/frame_sparc.hpp
> src/cpu/sparc/vm/frame_sparc.inline.hpp
> src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
> src/cpu/x86/vm/cppInterpreter_x86.cpp
> src/cpu/x86/vm/frame_x86.inline.hpp
> src/cpu/x86/vm/icache_x86.cpp
> src/cpu/x86/vm/icBuffer_x86.cpp
> src/cpu/x86/vm/interp_masm_x86_32.hpp
> src/cpu/x86/vm/interp_masm_x86_64.hpp
> src/cpu/x86/vm/interpreter_x86_32.cpp
> src/cpu/x86/vm/interpreter_x86_64.cpp
> src/cpu/x86/vm/jniFastGetField_x86_32.cpp
> src/cpu/x86/vm/jniFastGetField_x86_64.cpp
> src/cpu/x86/vm/metaspaceShared_x86_32.cpp
> src/cpu/x86/vm/metaspaceShared_x86_64.cpp
> src/cpu/x86/vm/methodHandles_x86.cpp
> src/cpu/x86/vm/nativeInst_x86.cpp
> src/cpu/x86/vm/relocInfo_x86.cpp
> src/cpu/x86/vm/runtime_x86_32.cpp
> src/cpu/x86/vm/runtime_x86_64.cpp
> src/cpu/x86/vm/sharedRuntime_x86_32.cpp
> src/cpu/x86/vm/sharedRuntime_x86_64.cpp
> src/cpu/x86/vm/stubGenerator_x86_32.cpp
> src/cpu/x86/vm/stubGenerator_x86_64.cpp
> src/cpu/x86/vm/templateInterpreter_x86_32.cpp
> src/cpu/x86/vm/templateInterpreter_x86_64.cpp
> src/cpu/x86/vm/templateTable_x86_32.cpp
> src/cpu/x86/vm/templateTable_x86_64.cpp
> src/cpu/x86/vm/vm_version_x86.cpp
> src/cpu/x86/vm/vtableStubs_x86_32.cpp
> src/cpu/x86/vm/vtableStubs_x86_64.cpp
> src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp
> src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
> src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp
> src/os_cpu/linux_x86/vm/os_linux_x86.cpp
> src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp
> src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp
> src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
> src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp
> src/os_cpu/windows_x86/vm/os_windows_x86.cpp
> src/os/bsd/vm/os_bsd.cpp
> src/os/bsd/vm/os_bsd.inline.hpp
> src/os/bsd/vm/osThread_bsd.cpp
> src/os/linux/vm/os_linux.cpp
> src/os/linux/vm/os_linux.inline.hpp
> src/os/linux/vm/osThread_linux.cpp
> src/os/solaris/vm/os_solaris.cpp
> src/os/solaris/vm/os_solaris.inline.hpp
> src/os/solaris/vm/osThread_solaris.cpp
> src/os/windows/vm/os_windows.cpp
> src/os/windows/vm/os_windows.inline.hpp
> src/os/windows/vm/osThread_windows.cpp
> src/share/vm/asm/assembler.cpp
> src/share/vm/asm/assembler.hpp
> src/share/vm/asm/assembler.inline.hpp
> src/share/vm/asm/codeBuffer.cpp
> src/share/vm/asm/codeBuffer.hpp
> src/share/vm/c1/c1_MacroAssembler.hpp
> src/share/vm/code/icBuffer.cpp
> src/share/vm/code/relocInfo.cpp
> src/share/vm/interpreter/interpreter.cpp
> src/share/vm/interpreter/interpreterRuntime.cpp
> src/share/vm/opto/compile.cpp
> src/share/vm/runtime/atomic.cpp
> src/share/vm/runtime/atomic.hpp
> src/share/vm/runtime/atomic.inline.hpp
> src/share/vm/runtime/frame.cpp
> src/share/vm/runtime/frame.hpp
> src/share/vm/runtime/sharedRuntime.cpp
> src/share/vm/runtime/stubCodeGenerator.cpp
>


More information about the hotspot-compiler-dev mailing list