RFR (S): 8003195 - AbstractAssembler should not store code pointers but use the CodeSection directly

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Nov 29 11:33:02 PST 2012


I don't like explicit casting of address to int64 or int32. I would prefer original code moved to codeBuffer as other functions.

An other good cleanup would be remove emit_word() and emit_long() which are very confusing sizewise. But it is for next round.

Thanks,
Vladimir


On Nov 29, 2012, at 8:07 AM, Bharadwaj Yadavalli wrote:

> Please review
> http://cr.openjdk.java.net/~bharadwaj/8003195/webrev/
> 
> This change is a result of applying the patch from Christian Thalinger attached in the bug report with a couple of minor tweaks and are for x86 architecture only.
> 
> Thanks,
> 
> Bharadwaj
> 



More information about the hotspot-compiler-dev mailing list