RFR (L): 7054512: Compress class pointers after perm gen removal

Christian Thalinger christian.thalinger at oracle.com
Mon Oct 1 14:05:27 PDT 2012


On Sep 24, 2012, at 12:37 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On Sep 20, 2012, at 9:25 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
> 
>> compilers and SA support for compressed klass pointers.
>> 
>> http://cr.openjdk.java.net/~roland/7054512/webrev.00/
> 
> src/cpu/sparc/vm/sparc.ad:
> 
> +instruct encodeKlass_not_null(iRegN dst, iRegP src) %{
> +  format %{ "encode_heap_oop_not_null $src, $dst" %}
> 
> +instruct decodeKlass_not_null(iRegP dst, iRegN src) %{
> +  format %{ "decode_heap_oop_not_null $src, $dst" %}
> 
> Copy-paste typo:  oop should be klass.
> 
> src/cpu/x86/vm/x86_64.ad:
> 
> +instruct storeImmNKlass(memory mem, immNKlass src)
> ...
> +  ins_encode %{
> +    address con = (address)$src$$constant;
> +    __ set_narrow_klass($mem$$Address, (Klass*)$src$$constant);
> +  %}
> 
> con is unused.
> 
> I haven't reviewed all files yet but I'm working on it...

The rest looks good.  There are some places where the indent is now off and I'd like to get them fixed but it's really up to you.

-- Chris

> 
> -- Chris
> 
>> 
>> Roland.
> 



More information about the hotspot-compiler-dev mailing list