Request for reviews (M): 7201026: add vector for shift count

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Oct 1 15:13:07 PDT 2012


We already have it, adlparse.cpp:

     else if      (!strcmp(ident, "match")) {
       // Allow one instruction have several match rules.

It looks like I added it 6 years ago :)

https://jbs.oracle.com/bugs/browse/JDK-6460965

I tried with this changes and it works :O

I will update webrev and resend it after some testing.

Thanks,
Vladimir

Christian Thalinger wrote:
> On Oct 1, 2012, at 5:20 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
> 
>>> http://cr.openjdk.java.net/~kvn/7201026/webrev
>> It looks good.
>> Why do we need a different node type for left and right shifts? Wouldn't a single one be sufficient?
> 
> Where is the multiple-match-rules-per-instruct RFE?  -- Chris
> 
>> Roland.
> 


More information about the hotspot-compiler-dev mailing list