Assembler_x86.cpp char buffer deallocation

[Vladimir Kozlov]

Vitaly,

It is common mistake to mix code generation time and runtime execution of the 
generated code. We need this buffer with a message during runtime execution so 
we can deallocate it during code generation.

Regards,
Vladimir

Vitaly Davidovich wrote:
> Hi Volker,
> 
> Yes sorry, I should've stated that I did see that it was guarded by 
> VerifyOops and I was just browsing the code - this is by no means some 
> production issue that I have.  Was just curious if I missed something.
> 
> Thanks
> 
> Sent from my phone
> 
> On Oct 9, 2012 9:47 AM, "Volker Simonis" <volker.simonis at gmail.com 
> <mailto:volker.simonis at gmail.com>> wrote:
> 
>     Hi Vitaly,
> 
>     it looks not very professional indeed, however it is only in debug
>     code or in code protected by development parameters (-XX:+VerifyOops)
>     so it will not cause any trouble in the production VM. Nevertheless it
>     should be cleaned up when somebody touches that file.
> 
>     Regards,
>     Volker
> 
>     On Tue, Oct 9, 2012 at 3:10 PM, Vitaly Davidovich <vitalyd at gmail.com
>     <mailto:vitalyd at gmail.com>> wrote:
>      > Hi guys,
>      >
>      > I noticed that assembler_x86.cpp has a few places where a char[]
>     is new()'d
>      > up to hold an error message when verifying an oop.  This buffer
>     is passed to
>      > the stub routine, but I can't find where this buffer is then
>      > deleted/deallocated.  Am I missing something? Apologies of this
>     is a silly
>      > question. :)
>      >
>      > Thanks
>      >
>      > Sent from my phone
>