Request for reviews (S): 8000623: tools/javac/Diagnostics/6769027/T6769027.java crashes in PSPromotionManager::copy_to_survivor_space

[Christian Thalinger]

Looks good.  -- Chris

On Oct 17, 2012, at 10:02 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> http://cr.openjdk.java.net/~kvn/8000623/webrev
> 
> We missed one place which loads java method's pointer (old MethodOop) from vtable when switched to NPG. The load is marked as oop load and as result method's pointer (which is in Metaspace now) ends up in oopmap.
> 
> I did not find any more similar places. But I found incorrect switch code which I fixed.
> 
> Note, diffs does not show indent change in compile.hpp:
> 
> http://cr.openjdk.java.net/~kvn/8000623/webrev/src/share/vm/opto/compile.hpp.patch
> 
> Thanks,
> Vladimir