Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Sep 24 19:04:13 PDT 2012


Christian Thalinger wrote:
> On Sep 21, 2012, at 4:43 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> http://cr.openjdk.java.net/~kvn/7200233/webrev
>>
>> Added missed _bottom_type set in ArchDesc::defineExpand().
>>
>> Added missed vector nodes in MatchRule::is_vector() and in vmStructs.
> 
> Looks good.  But wouldn't it be better to have some kind of array with all the vector names in it for MatchRule::is_vector?

Done:

http://cr.openjdk.java.net/~kvn/7200233/webrev.01

Thanks,
Vladimir

> 
> -- Chris
> 
>> Thanks,
>> Vladimir
> 


More information about the hotspot-compiler-dev mailing list