RFR (M): 7177003 C1: LogCompilation support

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Sep 26 09:54:12 PDT 2012


Looks good.

thanks,
Vladimir

Vladimir Ivanov wrote:
> Thank you, Vladimir and Chris.
> 
> Here are updated changes [1]:
> 	- merged with the latest changes in hotspot-comp
> 	- removed intx->int conversion as you suggested
> 	- removed "receiver is statically known" message from PrintInlining
> output, but left in it the log
> 
> Best regards,
> Vladimir Ivanov
> 
> [1] http://cr.openjdk.java.net/~vlivanov/7177003/webrev.01/
> 
> On 09/26/12 02:47, Vladimir Kozlov wrote:
>> Good changes!
>>
>> Small thing: in method.cpp and deoptimization.cpp remove (int) cast from
>> os::current_thread_id() if you want tou use UINTX format (it reads 64bit
>> in 64b VM).
>>
>> Thanks,
>> Vladimir
>>
>> Vladimir Ivanov wrote:
>>> 7177003: C1: LogCompilation support
>>> http://cr.openjdk.java.net/~vlivanov/7177003/
>>>
>>> LogCompilation support in C1 - both client [1] and tiered [2] modes.
>>>
>>> These changes are only for Hotspot. LogCompilation tool changes will
>>> be sent separately.
>>>
>>> Also:
>>>     - print code cache state (after each nmethod installation)
>>>       Example:
>>>      <code_cache
>>>         total_blobs='258'
>>>         nmethods='50'
>>>         adapters='133'
>>>         free_code_cache='98839808'
>>>         largest_free_block='98832512'/>
>>>
>>>     - consistent nmethod numbering between ordinary and OSR compilations
>>>     - correct printing of thread id's
>>>     - added missed tty locks where necessary
>>>
>>> Thanks!
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>>
>>> PS: actually, if it simplifies review, I can send cleanup/small
>>> enhancements as a separate change.  
>>> PPS: phew! Finally deciphered how deoptimization in C1 works =)
>>>
>>> [1]
>>> http://cr.openjdk.java.net/~vlivanov/7177003/webrev.00/compilation.client.log
>>>
>>> [2]
>>> http://cr.openjdk.java.net/~vlivanov/7177003/webrev.00/compilation.tiered.log
>>>


More information about the hotspot-compiler-dev mailing list