RFR(XXS) 8006014: [parfait] Memory leak at hotspot/src/share/vm/adlc/dfa.cpp

Niclas Adlertz niclas.adlertz at oracle.com
Wed Apr 3 11:48:46 PDT 2013


Thank you Roland.
Thank you Vladimir.

I've fixed the coding style. 

http://cr.openjdk.java.net/~adlertz/JDK-8006014/webrev02/

Regards,
Niclas Adlertz

On 3 apr 2013, at 19:25, Vladimir Kozlov wrote:

> Niclas,
> 
> We have agreement that we fix code style in touched code (and may be a little surrounding also):
> < if( mList._lchild ) {
> ---
> > if (mList._lchild) {
> 
> Also one of comments was moved to next line with strange indention. Please, fix it. And we don't need so many spaces between "}  //".
> 
> The code fix is good.
> 
> Thanks,
> Vladimir
> 
> On 4/3/13 8:38 AM, Niclas Adlertz wrote:
>> Hi all.
>> 
>> A very small parfait fix. A review would be much appreciated.
>> Thank you.
>> 
>> Regards,
>> Niclas Adlertz
>> 
>> -----------------------------------------------------------------
>> webrev: http://cr.openjdk.java.net/~adlertz/JDK-8006014/webrev00/
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8006014
>>   bugs: http://bugs.sun.com/view_bug.do?bug_id=8006014
>> 
>> 



More information about the hotspot-compiler-dev mailing list