RFR(M) : 7104565 : trim jprt build targets
Mikael Gerdin
mikael.gerdin at oracle.com
Thu Apr 4 00:56:24 PDT 2013
David,
On 2013-04-04 05:00, David Chase wrote:
> webrev: http://cr.openjdk.java.net/~drchase/7104565/webrev.02/
I noticed that the "udiff" for llvmHeaders.hpp in your webrev is broken:
http://cr.openjdk.java.net/~drchase/7104565/webrev.02/src/share/vm/shark/llvmHeaders.hpp.udiff.html
It doesn't show the removed lines at all.
Could you try to generate a webrev with the "standard" webrev script in
the top-level repo to rule out any bug in the "enhanced" webrev (the one
with next/prev file links).
/Mikael
>
> Problem:
> Debug builds are inconsistently named, and are not needed for usual JPRT testing, and consume lots of space and time.
> #ifdef conventions are a little dubious (I'm just paraphrasing from the bug here).
>
> Fix:
> Pick up Tom Rodriguez's work towards a fix (95+% complete),
> translate forward in time to current build, check for omissions and changes.
>
> Fix includes:
> replace #ifdef DEBUG and #ifdef FASTDEBUG with #ifdef ASSERT
> consistently name the debug build "debug" instead of "jvmg"
> remove "debug" targets from JPRT properties files.
>
> Testing:
> Jtreg locally
> JPRT of usual compiler tests
> Cross-checked old diffs with new diffs
> JPRT of compiler regression tests
> Manually check that appropriate -DASSERT flag is passed to compilations.
>
> Noticeable changes:
> "make debug", not "make jvmg"
> JPRT of compiler regression tests is much faster and times out much less often.
>
More information about the hotspot-compiler-dev
mailing list