RFR(M) : 7104565 : trim jprt build targets

Mikael Gerdin mikael.gerdin at oracle.com
Thu Apr 4 04:57:17 PDT 2013


David,

On 2013-04-04 13:41, Stefan Karlsson wrote:
> On 04/04/2013 01:08 PM, David Chase wrote:
>> On 2013-04-04, at 3:11 AM, Stefan Karlsson<stefan.karlsson at oracle.com>  wrote:
>>
>>> David,
>>>
>>> You change a lot of make files and this will affect all HotSpot developers, so this review should probably go to hotspot-dev and not hotspot-compiler-dev.
>>>
>>> Have you tried these changes with a full JDK8 forest and the new build infrastructure?
>> I can do that.  Does JPRT use new or old build?  (if it does, then in some sense I have already tested that way, and if it does not, then it is pointless to re-run JPRT on the full tree.)
>
> Neither, if you only sync the HotSpot forest.
>
>   You have to fetch the entire JDK8 forest, and then I _think_ JPRT will
> use the new build system. Though, I don't think it will build jvmg/debug
> per default. You need to build with the slowdebug target. You better ask
> build-infra-dev at openjdk.java.net <mailto:build-infra-dev at openjdk.java.net>.
>
>>
>> Two questions -- I noticed that I missed two versions of profiled.make (i.e., those files could be deleted).  But I am also unsure about the wisdom of getting rid of profiled make -- what is our method of profiling hotspot, if we do not have that build option?
>
> I have no knowledge about profiled.make.

I believe that profiled.make will compile hotspot with support for gprof 
& friends.
The problem with gprof is that it only works on binaries, not shared 
libraries. So with Christian T's change to remove the gamma launcher and 
thereby the LINK_INTO=AOUT make flag profiled.make will probably be 
completely useless.

Also, I think most people who want to profile the VM use sampling based 
profiling tools such as "perf", "collect/analyze" or VTune.

/Mikael

>
> thanks,
> StefanK
>
>>
>> David
>>
>


More information about the hotspot-compiler-dev mailing list