RFR (S): 8011198: LP64 setting is not preserved on Solaris after 8006965
Christian Thalinger
christian.thalinger at oracle.com
Thu Apr 4 12:13:53 PDT 2013
On Apr 4, 2013, at 12:11 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Thanks, Christian
Unrelated to this review I just found a typo in launcher.script:
$ ack JPAR ./src/os/posix/launcher/launcher.script
JPARMS="$@ $JAVA_ARGS";
set args $JPARMS
$DBX -s $MYDIR/.dbxrc $LAUNCHER $JPARAMS
$VALGRIND --tool=memcheck --leak-check=yes --num-callers=50 $LAUNCHER -Xmx16m $JPARMS
LD_PRELOAD=$PRELOADING exec $LAUNCHER $JPARMS
The DBX line uses JPARAMS instead of JPARMS.
-- Chris
>
> Vladimir
>
> On 4/4/13 11:50 AM, Christian Thalinger wrote:
>>
>> On Apr 4, 2013, at 11:24 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>>> http://cr.openjdk.java.net/~kvn/8011198/webrev/
>>>
>>> Fixed incremental build makefiles generated by buildtree.make.
>>
>> Sorry I removed the lines in 8006965. Thanks for fixing it.
>>
>>> Consolidated unix build.sh.
>>
>> Since you're probably the only one using I think it's fine :-)
>>
>>> Fixed launcher.script (hotspot) to use .dbxrc from HOME dir since 8006965 removed it from build dir.
>>
>> Ahh, thanks.
>>
>> Looks good.
>>
>> -- Chris
>>
>>>
>>> Tested with jprt.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>
More information about the hotspot-compiler-dev
mailing list