RFR(S) : 8011675: adding compilation level to replay data

[Igor Ignatyev]

Vladimir,

Thank you for review.

updated webrev: http://cr.openjdk.java.net/~iignatyev/8011675/webrev.01/

Best regards,
Igor Ignatyev

On 04/09/2013 04:19 AM, Vladimir Kozlov wrote:
> Igor,
>
> Thank you for fixing and cleaning this.
>
> In vmStructs.cpp move _comp_level after _compile_id as in nmethod class.
>
> Typo in ciReplay.cpp:
> +      comp_level != CompLevel_highest_tier;
>
> Actually it is useless to replay compilation at different level, it
> should exit with error. Could happened because incorrectly run without
> Tiered when the crush happened with Tiered.
>
> In ciReplay.cpp use parenthesis around equality checks: if (. && (. == .)).
>
> Thanks,
> Vladimir
>
> On 4/8/13 12:30 PM, Igor Ignatyev wrote:
>> Hi all,
>>
>> Please review patch.
>>
>> Problem:
>> Replay of compilations supports c1 and tiered as well as c2, the only
>> thing missing is comp_level.
>>
>> Fix:
>> 1. added comp_level into dump and usage during replay
>> 2. minor changes in agent/doc:
>>    - escaped '<', '>'
>>    - renamed 'C2 Replay'/'C2 compiler replay' to 'Replay'/'Compiler
>> replay'
>>
>> Testing:
>> manually launched the replay from JDK-8010934 (assert specifically to
>> c1) on jvm w/o corresponded fix. assert was triggered w/ patch and
>> wasn't triggered w/o.
>>
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8011675/webrev.00/
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011675