Request for review (XS): JDK-8011952: Missing ResourceMarks in TraceMethodHandles

[David Holmes]

Looks good to me!

Thanks,
David

On 11/04/2013 1:38 PM, Krystal Mo wrote:
> Hi everybody,
>
> Could I have a review for this small change, please?
>
> Webrev: http://cr.openjdk.java.net/~kmo/8011952/webrev.00/
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011952
>
> Description: (copied from CR)
>
> There are some TraceMethodHandles logic that uses Symbol::as_C_string(),
> but miss putting a ResourceMark in the appropriate scope, triggering
> assertions in debug builds when using -XX:+TraceMethodHandles.
>
> Testing:
>
> Testing with JPRT.
> Hand tested some programs using MethodHandles with VM flags:
> -XX:+TraceMethodHandles -XX:+Verbose, all of them hit assertion before
> change and pass after the change.
>
> Thanks,
> Kris
>