RFR(S) : 8011971 : WB API doesn't accept j.l.reflect.Constructor

[Vladimir Kozlov]

Igor,

Could you explain why you need j.l.reflect.Constructor in WB compiler 
tests? As java coding exercise it may be good (I am lost in it). But how 
it helps to JIT compiler testing?

Do you know about 'comments' in a code? :)

Using argument 'true' say nothing what it does since the corresponding 
code is in different class file:

+        super(testCase, true);

Why do you need to set dontinline in costructor?
Would be better explicitly call new method from CompilerWhiteBoxTest 
class when needed:

setDontInlineMethod() {
   WHITE_BOX.testSetDontInlineMethod(method, true);
}

Regards,
Vladimir

On 4/12/13 8:29 AM, Igor Ignatyev wrote:
> Hi all,
>
> Please review patch.
>
> 1. changed signature of all methods where j.l.reflect.Method is used
> 2. added tests which use j.l.reflect.Constructor
>
> webrev: http://cr.openjdk.java.net/~iignatyev/8011971/webrev.00/
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8011971