RFR(S): 8010770 : Zero: back port of 8000780 to HS24 broke JSR 292

[Volker Simonis]

Hi David,

thank you for dealing with this.

I'm not a formal reviewer, but as I wrote before, I can confirm that this
changes fixes JSR292 in the CC_Interpreter in hsx24.

For actual reviewers, here's a short description on how I build the ZERO-VM
on Linux/AMD64 and how I ran the java/lang/invoke JTreg tests:

in hsx24/hotspot/make (with the patch) do:

ALT_BOOTDIR=/share/software/Java/jdk1.7.0
ALT_OUTPUTDIR=../../output_64_zero_opt ARCH_DATA_MODEL=64 ZERO_BUILD=true
ZERO_LIBARCH=amd64 ZERO_ARCHDEF=AMD64 ZERO_ENDIANNESS=little
LIBFFI_LIBS=-lffi DEBUG_BINARIES=true JVM_VARIANT_ZERO=true make productzero

copy the resulting libjvm.so into a corresponding JDK image
('/tmp/j2sdk-image_for_zero' in my case) and do:

JT_JAVA=/tmp/j2sdk-image_for_zero
/share/software/Java/jtreg/linux/bin/jtreg
-J-Djunit.jar=/share/software/Java/junit4.5/junit-4.5.jar
-jdk:/tmp/j2sdk-image_for_zero
-dir:/usr/work/OpenJDK/ppc-aix-port/jdk7u/jdk/test
-reportDir:/tmp/jtreg/JTreport -workDir:/tmp/jtreg/JTwork
-timeoutFactor:100 java/lang/invoke

Note that the big 'timeoutFactor' is necessary in order to pass all tests.

Thank you and best regards,
Volker


On Sun, Apr 21, 2013 at 11:06 PM, David Chase <david.r.chase at oracle.com>wrote:

> Bug: changes made to Zero for jdk8 compatibility broke jsr292 when they
> were backported
> to HS24.  This patch fixes that.
>
> Fix: from Volker Simonis
> "I've just realized that something must have gone wrong during the
> downport of 8000780 to hsx24 (probably because of the change of the content
> of the f1 and f2 fields in the ConstantPoolCacheEntry between hsx24 and
> hsx25). Unfortunately now both, '_invokedynamic' as well as '_invokehandle'
> don't work in the CC-interpreter anymore. The attached patch (against
> hsx24) fixes the problem and lets the Zero-VM pass the java/lang/invoke
> JTreg tests again.
>
> These changes are needed for making JSR292 work in the Zero-port in jdk7u
> with hsx24."
>
> Testing:
> 1) jtreg with zero applied to jdk/test/java/lang/invoke -- very broken
> without patch, works with patch.
> 2) JPRT
> Repositories used for test:
> http://hg.openjdk.java.net/jdk7u/jdk7u-dev +
> http://hg.openjdk.java.net/hsx/hsx24/hotspot/hotspot
>
> Webrev: http://cr.openjdk.java.net/~drchase/8010770/webrev.00/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130422/53e7f969/attachment.html