RFR (XS): 8010460: Interpreter on some platforms loads ConstMethod::_max_stack and misses extra stack slots for JSR 292

Christian Thalinger christian.thalinger at oracle.com
Tue Apr 23 14:12:04 PDT 2013


On Apr 9, 2013, at 7:50 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:

> Here is a new webrev:
> 
> http://cr.openjdk.java.net/~roland/8010460/webrev.02/

src/share/vm/oops/method.hpp:

+  // How many extra stack entries for invokedynamic when it's enabled
+  static const extra_stack_entries_for_indy = 1;

Can we move this up to be next to:

+  static int extra_stack_entries() { return EnableInvokeDynamic ? extra_stack_entries_for_indy : 0; }

Perhaps we should call it extra_stack_entries_for_jsr292 since it's not only invokedynamic.

Otherwise this looks good.

-- Chris

> 
> It includes Volker's suggestions.
> The cpp interpreter is broken so I couldn't even test that it compiles.
> 
> Roland.



More information about the hotspot-compiler-dev mailing list