RFR (S) : 8022441

[Vladimir Kozlov]

Looks good.

Vladimir

On 8/9/13 6:51 AM, David Chase wrote:
>
> webrev:
> http://cr.openjdk.java.net/~drchase/8022441/webrev.01/8022441.patch
>
> bug:
> Porting this intrinsic to Graal, Doug Simon noticed some places where things were not right
> in the interpreted version of the intrinsic, though in ways that currently slip past our existing
> tests (I verified this by single-stepping the interpreter right over setting SP to 8, and which
> was later corrected -- at least for my run -- by subsequent code).  Three flaws:
> 1) botched SP restore
> 2) wrong registers (not conforming to convention) for Windows
> 3) rare corner case for negative numbers
>
> fix:
> correct problems
>
> testing:
> hand-verified by me;
> report of correct behavior from Doug Simon;
> JPRT focussed on the CRC test;
> Local jtreg on the CRC test, interpreted and not.
>
> David
>