RFR (L) : 8014013 : CallInfo structure no longer accurately reports the result of a LinkResolver operation

David Chase david.r.chase at oracle.com
Sun Aug 18 15:24:14 PDT 2013


A question about err_msg_res -- should that generally be used in place of err_msg,
or only in certain source directories, and if so, which ones?

On 2013-08-17, at 1:41 AM, John Rose <john.r.rose at oracle.com> wrote:

> On Aug 16, 2013, at 1:05 PM, David Chase <david.r.chase at oracle.com> wrote:
> 
>> How does this look?
>> 
>> void fieldDescriptor::reinitialize(InstanceKlass* ik, int index) {
>>  if (_cp.is_null() || field_holder() != ik) {
>>    _cp = constantPoolHandle(Thread::current(), ik->constants());
>>    // _cp should now reference ik's constant pool; i.e., ik is now field_holder.
>>    assert(field_holder() == ik, "must be already initialized to this class");
> 
> Good.
> 
> As a side note, this bit of code (and many others) assume that there is a 1-1 correspondence between constant pools and instance klasses.
> 
> I hope we can change this some day; the tracking bug is http://bugs.sun.com/view_bug.do?bug_id=6711913
> 
> — John

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130818/d413a3bf/signature.asc 


More information about the hotspot-compiler-dev mailing list