RFR(S) 8023988: Move local scheduling of nodes to the CFG creation and code motion phase (PhaseCFG)

Niclas Adlertz niclas.adlertz at oracle.com
Fri Aug 30 16:36:40 PDT 2013


Thank you Vladimir, yes we should, and probably also move PhaseCFG method definitions in block.cpp to a separate .cpp file.

Kind Regards,
Niclas Adlertz


On 30 aug 2013, at 20:08, Vladimir Kozlov <Vladimir.Kozlov at oracle.com> wrote:

> Niclas,
> 
> Changes are fine but I think it is time to move PhaseCFG class into separate header.
> 
> thanks,
> Vladimir
> 
> On 8/29/13 8:40 AM, Niclas Adlertz wrote:
>> Hi all,
>> 
>> The class PhaseCFG is responsible for creating the CFG and doing the global code motion. This should also include local scheduling of nodes within blocks.
>> I've moved all code related to local scheduling of nodes from class Block to class PhaseCFG. Now class Block looks more like the container it should be, and the local scheduling methods are no longer accessible from outside class PhaseCFG.
>> 
>> WEBREV: cr.openjdk.java.net/~adlertz/JDK-8023988/webrev00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8023988
>> 
>> Kind Regards,
>> Niclas Adlertz
>> 
>> 



More information about the hotspot-compiler-dev mailing list