RFR (XS) : 8027124 : [TESTBUG] NonTieredLevelsTest: java.lang.RuntimeException: private TestCase$Helper(java.lang.Object) must be osr_compiled

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Dec 2 13:30:12 PST 2013


Don't split the line:

+         if (testCase.isOsr && CompilerWhiteBoxTest.MODE.startsWith(
+                 "compiled ")) {

Why space needed "ed "?

I don't think we should pollute output with messages which does not 
help. Or this message is used to mark test passed?

Add comment.

thanks,
Vladimir


On 12/2/13 12:39 PM, Igor Ignatyev wrote:
> Hi all,
>
> Please review patch.
>
> Problem:
> OSR test cases in 'compiler/tiered' tests are not applicable in -Xcomp
> mode, since there is no way to provoke OSR compilation
>
> Fix:
> Added skipping of OSR test cases, if -Xcomp is enabled
>
> webrev: http://cr.openjdk.java.net/~iignatyev/8027124/webrev.00/
> jbs: https://bugs.openjdk.java.net/browse/JDK-8027124
> testing: compiler/tiered in -Xcomp, -Xmixed, -Xint and default mode


More information about the hotspot-compiler-dev mailing list