RFR(S) : 8029153 : [TESTBUG] test/compiler/7141637/SpreadNullArg.java fails because it expects NullPointerException
Igor Ignatyev
igor.ignatyev at oracle.com
Sun Dec 8 21:56:12 PST 2013
Hi Chris,
Thanks for review, I removed 'caught' variable and moved throw
statement. Also I added a message in order to simplify future
investigations of test's failures.
http://cr.openjdk.java.net/~iignatyev/8029153/webrev.01/
On 12/09/2013 05:40 AM, Christian Thalinger wrote:
> Instead of having a boolean caught you should move:
>
> + throw new Error("Expected IllegalArgumentException was not thrown”);
>
> inside the try-catch after the invokeExact.
>
> On Dec 8, 2013, at 11:35 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>
>> Hi all,
>>
>> Please review patch.
>>
>> Problem:
>> Test expects NPE, but after 8001109 spreader method handle throws IAE
>>
>> Fix:
>> Changed NPE to IAE in catch clause
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8029153/webrev.00/
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8029153
>> testing: failing test
>>
>> -- Igor
>
More information about the hotspot-compiler-dev
mailing list