Outdated comments in OptoRuntime::uncommon_trap_Type()

[Krystal Mok]

Hi all,

There's a bit of comment in OptoRuntime::uncommon_trap_Type():

  // Symbol* name of class to be loaded
  fields[TypeFunc::Parms+0] = TypeInt::INT;

It had been updated from "symbolOop name of class to be loaded", but this
earlier version had been outdated for quite some time. The parameter passed
into the uncommon trap stub is the "trap_reason", which is an int that
combines the DeoptReason and DeoptAction, instead of a symbolOop or Symbol*
for the name of class to be loaded. Would anybody fix this trivial thing,
please?

diff -r 8beff993531a src/share/vm/opto/runtime.cpp
--- a/src/share/vm/opto/runtime.cpp Thu Dec 12 18:57:38 2013 -0500
+++ b/src/share/vm/opto/runtime.cpp Fri Dec 13 11:35:21 2013 -0800
@@ -568,8 +568,7 @@
 const TypeFunc *OptoRuntime::uncommon_trap_Type() {
   // create input type (domain)
   const Type **fields = TypeTuple::fields(1);
-  // Symbol* name of class to be loaded
-  fields[TypeFunc::Parms+0] = TypeInt::INT;
+  fields[TypeFunc::Parms+0] = TypeInt::INT; // trap_reason (deopt reason
and action)
   const TypeTuple *domain = TypeTuple::make(TypeFunc::Parms+1, fields);

   // create result type (range)

Thanks,
- Kris (OpenJDK ID: kmo)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20131213/dd21308b/attachment.html