RFR(XXS): 8028052: compiler/startup/SmallCodeCacheStartup.java fails there is no 'no space to run compiler' in the output

Albert Noll albert.noll at oracle.com
Thu Dec 19 03:52:00 PST 2013


Hi,

could I get reviews for this small patch?

bug: https://bugs.openjdk.java.net/browse/JDK-8028052
webrev: http://cr.openjdk.java.net/~anoll/8028052/webrev.00/

Problem: The test assumes the existence of a C1 compiler. Not all VM 
configurations
have a C1 compiler. E.g., ARM server VM has only C2 - that is why the 
test fails.

Solution: Weaken test. Instead of checking for the expected warning that 
is printed
by the VM ('no space to run compiler'), the test passes if the VM does 
not crash. I think
weakening the test is fine since it still tests the cause of the 
original crash (8023014).

Best,
Albert




More information about the hotspot-compiler-dev mailing list