RFR (XS): 8007403: Incorrect format arguments in adlparse.cpp

Mikael Vidstedt mikael.vidstedt at oracle.com
Fri Feb 1 14:43:12 PST 2013


Yes, sorry - I did play around with removing suitable parts of the 
information in the x86_64.ad file and I verified that the printed error 
messages looked correct. I admit that I don't think I managed to trigger 
all the different parse_err calls, but my naive thinking is that they 
all behave the same way so they're either all correct or all incorrect.

Cheers,
Mikael

On 2/1/2013 1:54 PM, Vladimir Kozlov wrote:
> Mikael,
>
> Did you verify that it work as expected by modifying .ad file and 
> triggering an error message?
>
> Thanks,
> Vladimir
>
> On 2/1/13 1:16 PM, Mikael Vidstedt wrote:
>>
>> All,
>>
>> Please review the following change:
>>
>> http://cr.openjdk.java.net/~mikael/8007403/webrev.01/webrev/
>>
>> Background: The error message strings passed to parse_err() are
>> eventually passed into a printf type function, and therefore the strings
>> need to be on a printf friendly format. In effect that means all the
>> '%{' should be '%%{'.
>>
>> Cheers,
>> Mikael
>>



More information about the hotspot-compiler-dev mailing list