RFR(M): 7197327: 40% regression on 8 b41 comp 8 b40 on specjvm2008.mpegaudio on oob

Roland Westrelin roland.westrelin at oracle.com
Mon Feb 4 13:35:45 PST 2013


Vladimir,

Thanks for the review.

> We usually put asserts at the beginning of methods (before any checks):
> assert(OptimizeExpensiveOps, "optimization off?");

Compile::should_optimize_expensive_nodes() and Compile::cleanup_expensive_nodes() are called whether OptimizeExpensiveOps is on or off. So If the assert is moved at the start of theses methods, and OptimizeExpensiveOps is false, it will always fire. The _expensive_nodes->length() == 0 must be first.

Roland.


More information about the hotspot-compiler-dev mailing list