Request for Reviews (S): 8007402: Code cleanup to remove Parfait false positive

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Feb 8 20:50:08 PST 2013


On 2/8/13 8:21 PM, David Chase wrote:
> Is that style?
> I was unclear on whether an implementation-side restriction should appear in a header file,
> or if it was important that they match.
> There were no compiler warnings.

It is strange, I thought C++ requires matching arguments declarations.
Anyway, we do always match them in our code. So, please, fix it.

> Does this require another JPRT run to guard against C++ compiler glitches on other platforms?

Unfortunately, yes.

Thanks,
Vladimir

>
> On 2013-02-08, at 10:25 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
>> David,
>>
>> I don't see changes to methods declaration in header file regmask.hpp.
>>
>> Thanks,
>> Vladimir
>


More information about the hotspot-compiler-dev mailing list